-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: (core) Update popover's usage of side nav, add important files of popover to public_api.ts #1645
Conversation
Deploy preview for fundamental-ngx ready! Built with commit 96b098d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it needs rebasing but I still see the third level of navigation in the examples. Also, the padding's not correct in the example with only text.
When there's only text, the second level items should have 2rem left padding. The next level adds +1rem padding and so on. In NGX the second level items have 2.5rem left padding.
b799612
to
7c33c55
Compare
Hi @InnaAtanasova I think this issue occurs, cause of netlify's cache issues. I think we can merge it. |
79f8b4c
to
a86974b
Compare
8721f88
to
96b098d
Compare
@InnaAtanasova Changes fixing the padding are included now. I also removed 2nd level icons. |
Hi @InnaAtanasova , @stefanoScalzo I think these comments went too far. This PR was only about fixing side-nav usage on |
Please provide a link to the associated issue.
fixes: #1644
Please provide a brief summary of this pull request.
There is new side navigation component usage on popover's last example.
Also during implementation I noticed that there are some files missing in popover's public_api,ts
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md