fix: (core) Add Additional class to popover component, introduce nested popover example #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 02ce757 |
JKMarkowski
changed the title
JKMarkowski
force-pushed
the
fix/1633-popover-additional-class
branch
from
5d43e4a
to
a9cf053
Compare
|
To be honest I don't know how I feel about this nested popover...
|
InnaAtanasova
requested changes
Nov 25, 2019
|
Hi @InnaAtanasova, this is just to show, how user can inject classes to element. |
|
I agree with @InnaAtanasova. It looks odd the way it appears. |
JKMarkowski
force-pushed
the
fix/1633-popover-additional-class
branch
from
a9cf053
to
b2d9616
Compare
JKMarkowski
force-pushed
the
fix/1633-popover-additional-class
branch
from
b2d9616
to
973d565
Compare
|
Nested class example is removed. |
| @@ -756,7 +756,7 @@ import { SelectTypesExampleComponent } from './component-docs/select/examples/se | |||
| NotificationContentComponent, | |||
| DatePickerComplexI18nExampleComponent, | |||
| DatetimePickerComplexI18nExampleComponent, | |||
| PopoverDropdownComponent | |||
| PopoverDropdownComponent, | |||
InnaAtanasova
approved these changes
Dec 30, 2019
salarenko
approved these changes
Dec 31, 2019
JKMarkowski
force-pushed
the
fix/1633-popover-additional-class
branch
from
973d565
to
02ce757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
fixes: #1633
Please provide a brief summary of this pull request.
There is added new property on popover, to add custom classlist for popover container. It was missing mostly, when user wanted to put popover inside popover, to differentiate them.
I added also interesting use case with
nested-popover, as example.Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md