fix(platform): menu component library review fixes #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 4dc47f2 |
kavya-b
changed the title
kavya-b
force-pushed
the
platform-menu-code-change
branch
from
71e9035
to
1c281fe
Compare
1. Using fd-icon instead of span classes 2. fixing item offset calculation when icons are present in an edge case 3. adding longer if conditions into their own methods 4. added a new type FdpItem instead of MenuItem|MenuGroup and changed examples to reflect the same 5. removed !==undefined comparisons 6. Using dropdown popover with button instead of deprecated fd-dropdown-control
kavya-b
force-pushed
the
platform-menu-code-change
branch
from
1c281fe
to
4dc47f2
Compare
libs/platform/src/lib/components/menu/menu-component/menu-item.component.ts
Show resolved
Hide resolved
KevinOkamoto
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#1710
Please provide a brief summary of this pull request.
Address PR #1563 comments by Frank: #1563 (comment)
Additionally,
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md