feat: rewrite Checkbox as a separate module | suit to Fiori3 #1777
Conversation
|
Deploy preview for fundamental-ngx ready! Built with commit 26be28b |
| return this.checkboxState === 'indeterminate'; | ||
| } | ||
|
|
||
| writeValue(value: any): void { |
There was a problem hiding this comment.
Let's mark methods, that are implemented from ControlValueAccessor as /** @hidden */, they shouldn't be in documentation IMO. Let's shortly describe all of other methods.
InnaAtanasova
changed the title
InnaAtanasova
changed the title
| code: formGroupInputTs, | ||
| fileName: 'checkbox-form-group-example', | ||
| component: 'CheckboxFormGroupExampleComponent' | ||
| language: 'TypeScript', |
There was a problem hiding this comment.
typescript should have lower case 't' for stackblitz to work
| ngOnInit() { } | ||
| checkboxReactiveForms: ExampleFile[] = [ | ||
| { | ||
| language: 'TypeScript', |
|
|
||
| checkboxStates: ExampleFile[] = [ | ||
| { | ||
| language: 'TypeScript', |
| } | ||
| ]; | ||
|
|
||
| checkboxCustomValues: ExampleFile[] = [ | ||
| { |
There was a problem hiding this comment.
You need to add the html as well for all
| expect(checkbox.checkboxValue).toBe(false); | ||
| }); | ||
|
|
||
| // it('should be unchecked on double click', () => { |
There was a problem hiding this comment.
What are all of these comments for. IF they are necessary remove the ones with nothing inside
There was a problem hiding this comment.
Test cases have been updated
|
|
||
| /** Values returned by control. */ | ||
| @Input() | ||
| values: FdCheckboxValues = {trueValue: true, falseValue: false, thirdStateValue: null}; |
There was a problem hiding this comment.
I know by doing this we are giving them flexibility but shouldn't a checkbox be strictly a boolean ?
There was a problem hiding this comment.
Checkbox control returns boolean values by default.
I think giving user possibility to define values returned by checkbox is a nice and useful feature.
| * */ | ||
| public nextValue(): void { | ||
|
|
||
| if (this.disabled) { |
salarenko
force-pushed
the
feat/1769-fiori3-checkbox
branch
from
d28c0be
to
1199c9d
Compare
salarenko
force-pushed
the
feat/1769-fiori3-checkbox
branch
from
874683b
to
ec07905
Compare
I complete agree with Jedrzej . Great job! |
|
The build is failing. Could you take a look at it? |
salarenko
force-pushed
the
feat/1769-fiori3-checkbox
branch
from
ec07905
to
0a33c97
Compare
…kbox using compareObjects
…ocumentation examples using old versions of checkbox
salarenko
force-pushed
the
feat/1769-fiori3-checkbox
branch
from
0a33c97
to
7c1d534
Compare
* Working cheeckbox implementation * Create documentation examples * Add checkbox interface annotations * feat(core): update unit tests * feat(core) Update checkbox api description * core(feat) Working unit tests for checkbox * feat(core) Introduce compareObjects function | Compare values in checkbox using compareObjects * core(feat) Review changes * feat(core) Remove checkbox support in FormControlDirective | Update documentation examples using old versions of checkbox * feat(core) fix circular dependencies * feat(core) Add custom label example | Add files indexing * feat(core) Change encapsulation and change detection strategy * feat(core) Make MultiInput tests async
Please provide a link to the associated issue.
closes #1769
Please provide a brief summary of this pull request.
This pull requests includes:
Checkbox state is driven by value passed to component by FormControl.
Please check whether the PR fulfills the following requirements
Documentation checklist: