Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null check in decorator added #1784

Merged

Conversation

rengare
Copy link
Contributor

@rengare rengare commented Jan 7, 2020

Please provide a brief summary of this pull request.

Please check whether the PR fulfills the following requirements

Added a null checks for elementRef

@netlify
Copy link

netlify bot commented Jan 7, 2020

Deploy preview for fundamental-ngx ready!

Built with commit b35ee67

https://deploy-preview-1784--fundamental-ngx.netlify.com

@InnaAtanasova InnaAtanasova changed the title Feat/null check in decorator added fix: null check in decorator added Jan 7, 2020
@InnaAtanasova
Copy link
Contributor

InnaAtanasova commented Jan 7, 2020

@rengare , I believe this is not introducing Breaking Changes??? I renamed the title to fix (for the versioning and the release notes)

Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@InnaAtanasova InnaAtanasova merged commit 56b0914 into SAP:master Jan 9, 2020
@rengare rengare deleted the feat/null-check-in-decorator-added branch January 13, 2020 14:06
Lokanathan-k pushed a commit that referenced this pull request Feb 3, 2020
* upstream synced with fork

* added null check for elementRef

* removed changes from new_component and readme

* changes removed from readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants