fix: Add two digits pipe to time component #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
force-pushed
the
fix/add-two-digits-time
branch
from
651a482
to
5594428
Compare
|
Deploy preview for fundamental-ngx ready! Built with commit 651a482 |
|
Deploy preview for fundamental-ngx ready! Built with commit 73b2e14 |
JKMarkowski
force-pushed
the
fix/add-two-digits-time
branch
from
5594428
to
048b04a
Compare
|
Looks ok for me |
InnaAtanasova
approved these changes
Jan 13, 2020
JKMarkowski
force-pushed
the
fix/add-two-digits-time
branch
from
0d4b586
to
73b2e14
Compare
Lokanathan-k
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Add two digits pipe to time component * Add example on docs * Fix tests * Change title of example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a brief summary of this pull request.
This is response for #1796 . There was requested two digits forcing on time and time related components. So I added flag, which keeps 2 digits, by adding 0. It's disabled by default.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md