feat: form messages adoption from styles 4.0 #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanoScalzo
requested review from
mikerodonnell89,
JKMarkowski and
InnaAtanasova
stefanoScalzo
force-pushed
the
feat/form-messages
branch
from
cb4f519
to
6183a10
Compare
|
Deploy preview for fundamental-ngx ready! Built with commit cb4f519 |
|
Deploy preview for fundamental-ngx ready! Built with commit a1536a6 |
JKMarkowski
suggested changes
Jan 17, 2020
There was a problem hiding this comment.
Good Job @stefanoScalzo, please solve issues from comments and we can merge it.
libs/core/src/lib/form/form-input-message-group/form-input-message-group.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/form/form-input-message-group/form-input-message-group.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/form/form-input-message-group/form-input-message-group.component.ts
Show resolved
Hide resolved
stefanoScalzo
changed the title
stefanoScalzo
force-pushed
the
feat/form-messages
branch
from
58c9d93
to
792cfa2
Compare
JKMarkowski
force-pushed
the
feat/form-messages
branch
2 times, most recently
from
765ce2c
to
f55d021
Compare
JKMarkowski
force-pushed
the
feat/form-messages
branch
from
f55d021
to
5dcd266
Compare
rengare
approved these changes
Jan 20, 2020
JKMarkowski
approved these changes
Jan 20, 2020
InnaAtanasova
approved these changes
Jan 20, 2020
Lokanathan-k
pushed a commit
that referenced
this pull request
Feb 3, 2020
* mmake messages popover for angular * add text area * blank * remove scss popover * resolve comments * remove ps * Apply PR comments fixes, add more message options, change comments * Minor import fix * Add new component to api files Co-authored-by: jmarkowski <jdrekmarkowski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#1811
Please provide a brief summary of this pull request.
Adding the new form-input-message-group component which uses the fd-form-input-message class.
Added input for the fd-popover for the popover container since the div might need extra classes added for whatever reasons. In this case I needed it for the width of the inputs.
Note: there are styling errors in text area which will be fixed in a pr in fundamental styles such as the z-index for text areas and the margins for both inputs and textareas
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md