Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (combobox) - reorder event throw #1831

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix: (combobox) - reorder event throw #1831

merged 1 commit into from
Jan 17, 2020

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Jan 17, 2020 •
edited by InnaAtanasova

Please provide a link to the associated issue.

#1811

Please provide a brief summary of this pull request.

I changed the order of setting value / throwing it. Before invalid old value was thrown,

Please check whether the PR fulfills the following requirements

Documentation checklist:

@netlify
Copy link

netlify bot commented Jan 17, 2020

Deploy preview for fundamental-ngx ready!

Built with commit c15267d

https://deploy-preview-1831--fundamental-ngx.netlify.com

@InnaAtanasova InnaAtanasova added this to In progress in Development via automation Jan 17, 2020
@InnaAtanasova InnaAtanasova added this to the Sprint 28 - Sydney milestone Jan 17, 2020
@InnaAtanasova InnaAtanasova merged commit f1988d1 into master Jan 17, 2020
Development automation moved this from In progress to Done Jan 17, 2020
@droshev droshev deleted the fix/combobox-event-order branch January 21, 2020 02:43
Lokanathan-k pushed a commit that referenced this pull request Feb 3, 2020
@JKMarkowski @Lokanathan-k
fix: (combobox) - event throw reorder (#1831)
4628b37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@rengare rengare rengare approved these changes

@salarenko salarenko salarenko approved these changes

@droshev droshev Awaiting requested review from droshev

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

@stefanoScalzo stefanoScalzo Awaiting requested review from stefanoScalzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 28 - Sydney
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JKMarkowski @mikerodonnell89 @rengare @salarenko @InnaAtanasova