Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1845 storybook integration #1862

Merged
merged 8 commits into from Jan 28, 2020
Merged

feat: #1845 storybook integration #1862

merged 8 commits into from Jan 28, 2020

Conversation

rengare
Copy link
Contributor

@rengare rengare commented Jan 27, 2020 •
edited by InnaAtanasova

#1845

Please provide a brief summary of this pull request.

PR adds storybook to ngx which is used as playground

Please check whether the PR fulfills the following requirements

@netlify
Copy link

netlify bot commented Jan 27, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 1f64d83

https://deploy-preview-1862--fundamental-ngx.netlify.com

@InnaAtanasova InnaAtanasova changed the title Feat/storybook feat: storybook integration Jan 27, 2020
@InnaAtanasova InnaAtanasova changed the title feat: storybook integration feat: #1845 storybook integration Jan 27, 2020
@droshev droshev added this to In progress in Development via automation Jan 27, 2020
@droshev droshev added the tooling tooling feature around fundamental-ngx label Jan 27, 2020
@droshev droshev added this to the Sprint 29 - Venice milestone Jan 27, 2020
@droshev
Copy link
Contributor

droshev commented Jan 28, 2020

@rengare I would classify this as chore - it doesn't change the API and it doesn't add features

@rengare rengare merged commit 8cbedde into master Jan 28, 2020
Development automation moved this from In progress to Done Jan 28, 2020
@droshev droshev deleted the feat/storybook branch January 28, 2020 15:38
Lokanathan-k pushed a commit that referenced this pull request Feb 3, 2020
@rengare @Lokanathan-k
feat: #1845 storybook integration (#1862)
1d554db 
* save

* added radio button stories

* added accessibility plugin

* working on storybook

* added fd-toggle story

* removed unused import

* added props to checkbox story

* package lock updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

@fkolar fkolar Awaiting requested review from fkolar

@salarenko salarenko Awaiting requested review from salarenko

@stefanoScalzo stefanoScalzo Awaiting requested review from stefanoScalzo

Assignees
No one assigned
Labels
tooling tooling feature around fundamental-ngx
Projects
None yet
Milestone
Sprint 29 - Venice
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rengare @droshev @InnaAtanasova