New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: table checkbox #1975
docs: table checkbox #1975
Conversation
Deploy preview for fundamental-ngx ready! Built with commit 967e35d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Not the correct prefix for the PR title
- Could you use
compact
modifier for the checkboxes? They look huge (the default is cosy which is used in mobile devices) - Please add Project and labels to the PR
- Please remove the lines of code that were changed because of reformatting of the code. Thanks
this.selectedRows.push(row); | ||
console.log(this.tableRows); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the console.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments have to be addressed
2dd592b
to
893c0a2
Compare
893c0a2
to
140d88f
Compare
@InnaAtanasova @rengare can you review the PR once more, please? |
Please provide a link to the associated issue.
defect hunting
Please provide a brief summary of this pull request.
Put the new implementation of checkboxes on table
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md