docs: (rtl) add RTL support for examples of scroll spy #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
requested review from
mikerodonnell89,
droshev,
rengare,
salarenko,
InnaAtanasova and
stefanoScalzo
|
Deploy preview for fundamental-ngx ready! Built with commit 2660813 |
InnaAtanasova
changed the title
JKMarkowski
force-pushed
the
docs/rtl-scroll-spy
branch
from
2660813
to
6389062
Compare
|
It's ready to be reviewed. Example is mirrored on RTL |
JKMarkowski
changed the title
droshev
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Please provide a brief summary of this pull request.
There was a need to add some
csscode to generalstyles.scss, because scroll spy components are encapsulated.Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md