fix: pagination RTL idea #2001
Merged
fix: pagination RTL idea #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerodonnell89
requested review from
droshev,
rengare,
salarenko,
JKMarkowski,
InnaAtanasova and
stefanoScalzo
|
Deploy preview for fundamental-ngx ready! Built with commit 076a492 |
mikerodonnell89
changed the title
rengare
force-pushed
the
fix/pagination-rtl
branch
from
99dc6b5
to
2dbd04a
Compare
JKMarkowski
previously requested changes
Feb 19, 2020
droshev
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Closes #1967
Please provide a brief summary of this pull request.
Simply using
dir="rtl"won't flip the array of numbers presented in the*ngFor. Here I'm using the RtlService and forcingdir="ltr"and reversing the array using a pipe. This feels code-smelly so I'd love to get some other opinionsBefore:
After: