Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: product switch drag and drop blue box issue #2019

Merged
merged 1 commit into from Feb 20, 2020

Conversation

mikerodonnell89
Copy link
Member

Please provide a link to the associated issue.

#2014

@netlify
Copy link

netlify bot commented Feb 19, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 1e168b7

https://deploy-preview-2019--fundamental-ngx.netlify.com

.fd-product-switch__item {
.fd-product-switch__title {
&:before, &:after {
background-color: white;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a theming parameter for that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole file has hard-coded values

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - we should address it in a separate issue

@droshev droshev added bug Something isn't working v.0.14.0 labels Feb 19, 2020
@droshev droshev added this to In progress in Development via automation Feb 19, 2020
@droshev droshev added this to the Sprint 31 - Sofia milestone Feb 19, 2020
@droshev droshev self-requested a review February 20, 2020 00:49
Development automation moved this from In progress to Reviewer approved Feb 20, 2020
@mikerodonnell89 mikerodonnell89 merged commit c609b9d into master Feb 20, 2020
Development automation moved this from Reviewer approved to Done Feb 20, 2020
@droshev droshev deleted the fix/product-switch-dnd-rectangle branch February 20, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants