feat(platform): Adding initial code for new platform menu. #2117
Conversation
The new platform menu models itself after the Angular Material Menu. Instead of being one component "button" plus "dropdown menu", the "dropdown menu" is a separate compoent and can be attached/opened by any element using a "trigger" directive. Fixing lint issue Adding new menu documentation Updating Menu documentation Adding menu in a scrollable container example Updating menu examples Adding aria-* attributes to menu trigger Adding automatic generation of menu ID transferring focus to child button
|
Deploy preview for fundamental-ngx ready! Built with commit ac326f5 |
|
| font-weight: 400; | ||
| font-size: 0.75rem; | ||
| text-align: center; | ||
| content: '\e066'; |
There was a problem hiding this comment.
Fiori team says although right arrow should be used to show a submenu, we shouldn't be restricting it to this particular icon in our code. @droshev could you please confirm if using it in this way is okay or should we provide developer the means to place his own icon instead?
There was a problem hiding this comment.
- When navigating through mouse, on clicking a submenu item, the parent menu closes. But when navigating through keyboard, on clicking a submenu item, the parent menu does not close. Shouldn't this behaviour be consistent?
All parent menus should close when "mouse clicking" or "keyboard typing enter" on a leaf node.
I can't seem to reproduce the behavior you're describing.
- Can we add an example that shows icons, separator lines and a longer menu with scrolling inside the menu; basically something like what the earlier 'complex menu' example had?
I'll try and add the additional examples. Scrolling has not been implemented - I'll try to add that feature as well.
There was a problem hiding this comment.
@kavya-b I think I'm going to wait for the fundamental-styles update (0.8.x? the one with updated Menu styles) before adding examples with icons and separator lines. I'm guessing I'll have to redo the component templates when the update occurs.
| public click(): void { | ||
| this.itemClick.emit(); | ||
|
|
||
| ngOnInit() { } |
There was a problem hiding this comment.
you can probably remove this one as its not used..
…l-ngx into okamoto/new-platform-menu
* feat(platform): Adding initial code for new platform menu. The new platform menu models itself after the Angular Material Menu. Instead of being one component "button" plus "dropdown menu", the "dropdown menu" is a separate compoent and can be attached/opened by any element using a "trigger" directive. Fixing lint issue Adding new menu documentation Updating Menu documentation Adding menu in a scrollable container example Updating menu examples Adding aria-* attributes to menu trigger Adding automatic generation of menu ID transferring focus to child button * Removing focus handler * Fixing unit tests
Please provide a link to the associated issue.
N/A
Please provide a brief summary of this pull request.
The new platform menu models itself after the Angular Material Menu. Instead of being one component "button" plus "dropdown menu", the "dropdown menu" is a separate component and can be attached/opened by any element using a "trigger" directive.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md