Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove product switch bullets #2165

Merged
merged 5 commits into from
Mar 19, 2020
Merged

fix: remove product switch bullets #2165

merged 5 commits into from
Mar 19, 2020

Conversation

stefanoScalzo
Copy link
Contributor

@stefanoScalzo stefanoScalzo commented Mar 12, 2020 •
edited

Please provide a link to the associated issue.

fixes: #2164

Please provide a brief summary of this pull request.

  • This PR will fix the bullets on the product switch.
  • It needs to be done in NGX because it is not strictly following the styles template for the drag and drop option.
  • Fundamental-React and Vue would also need to be notified

Please check whether the PR fulfills the following requirements

Documentation checklist:

Screen Shot 2020-03-19 at 9 15 31 AM
Screen Shot 2020-03-19 at 9 15 47 AM

@stefanoScalzo stefanoScalzo requested a review from a team March 12, 2020 14:58
@netlify
Copy link

netlify bot commented Mar 12, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 9076f39

https://deploy-preview-2165--fundamental-ngx.netlify.com

@stefanoScalzo stefanoScalzo added the bug Something isn't working label Mar 12, 2020
@stefanoScalzo stefanoScalzo added this to In progress in Development via automation Mar 12, 2020
@stefanoScalzo stefanoScalzo added this to the Sprint 32 - Miami milestone Mar 12, 2020
droshev
droshev previously requested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefanoScalzo it is good you reformatted the code but i think this should happen in a separate PR.
Can you keep only the fix in this one?

Development automation moved this from In progress to Review in progress Mar 13, 2020
@InnaAtanasova InnaAtanasova self-requested a review March 15, 2020 18:05
InnaAtanasova
InnaAtanasova previously requested changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add meaningful title for the PR and follow the Contribution guidelines.

@stefanoScalzo stefanoScalzo changed the title fix:product switch bullets fix: remove product switch bullets Mar 18, 2020
@stefanoScalzo
Copy link
Contributor Author

Please add meaningful title for the PR and follow the Contribution guidelines.

fixed

@stefanoScalzo
Copy link
Contributor Author

@stefanoScalzo it is good you reformatted the code but i think this should happen in a separate PR.
Can you keep only the fix in this one?

fixed

@stefanoScalzo stefanoScalzo dismissed stale reviews from InnaAtanasova and droshev March 19, 2020 00:17

rerequested

@rengare
Copy link
Contributor

rengare commented Mar 19, 2020

@stefanoScalzo please attach before and after screenshots

@stefanoScalzo
Copy link
Contributor Author

@stefanoScalzo please attach before and after screenshots

Because stackblitz only goes off of merged PRs and latest pre releases I posted screenshots showing what happens when u remove the docs styling. In mine, there are no docs stying

Development automation moved this from Review in progress to Reviewer approved Mar 19, 2020
@stefanoScalzo stefanoScalzo merged commit fb9aab1 into master Mar 19, 2020
Development automation moved this from Reviewer approved to Done Mar 19, 2020
@stefanoScalzo stefanoScalzo deleted the fix/product-switch-bullets branch March 19, 2020 14:19
DeepakSap14 pushed a commit that referenced this pull request Mar 30, 2020
@stefanoScalzo @DeepakSap14
fix: remove product switch bullets (#2165)
42d3edf 
* fix the dots

* remove from docs

* remove refactoring

* remove refactoring

* removed prettier officially
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@JKMarkowski JKMarkowski JKMarkowski approved these changes

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

Assignees

@stefanoScalzo stefanoScalzo

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 33 - London
Development

Successfully merging this pull request may close these issues.

Product switch bullets
5 participants
@stefanoScalzo @rengare @droshev @JKMarkowski @InnaAtanasova