fix: Make properties DND IE11 compatible #2196
Merged
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 0306bac |
InnaAtanasova
changed the title
JKMarkowski
force-pushed
the
fix/dnd-ie11
branch
from
33ebbc0
to
9663615
Compare
rengare
approved these changes
Mar 19, 2020
JKMarkowski
force-pushed
the
fix/dnd-ie11
branch
from
45cb047
to
96b42b0
Compare
JKMarkowski
force-pushed
the
fix/dnd-ie11
branch
from
96b42b0
to
0306bac
Compare
DeepakSap14
pushed a commit
that referenced
this pull request
Mar 30, 2020
* fix (dnd): Make properties DND IE11 compatible * Fix tests / add nullcheck * Fix DND tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
One of #2192
Please provide a brief summary of this pull request.
There are some native JS methods replaced, because of IE11 compatibility
getBoundingClientRect().x/ytogetBoundingClientRect().left/topandelement.remove()toelement.parentNode.removeChild(element)Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md