fix: IE11 crash by avoiding argument-less calls to classList.add #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for fundamental-ngx ready! Built with commit b60c266 |
JKMarkowski
approved these changes
Apr 2, 2020
salarenko
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#2252
And it's the same issue and the same solution as in mapbox/mapbox-gl-draw#479
Please provide a brief summary of this pull request.
On click of Buttons of Components like Datepicker, Combobox, and so on this issue is triggered because IE11 cannot handle empty Arrays on a spread operator e.g.
...this.additionalClasses. Second thing is that the Array should be queried by.length > 0otherwise the statement will be always true.Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md