Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken toolbar replaced by Shellbar #2254

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

rengare
Copy link
Contributor

@rengare rengare commented Apr 2, 2020

Please provide a brief summary of this pull request.

Toolbar replaced by shellbar

Please check whether the PR fulfills the following requirements

Before

image

After

image

@rengare rengare added bug Something isn't working documentation There is an issue with documentation v.0.16.0 labels Apr 2, 2020
@rengare rengare added this to the Sprint 34 - Głogów milestone Apr 2, 2020
@rengare rengare requested a review from a team April 2, 2020 13:13
@rengare rengare self-assigned this Apr 2, 2020
@rengare rengare added this to In progress in Development via automation Apr 2, 2020
@InnaAtanasova InnaAtanasova changed the title fix: broken toolpar repalced by shellbar docs: replace broken toolbar with Shellbar Apr 2, 2020
@netlify
Copy link

netlify bot commented Apr 2, 2020

Deploy preview for fundamental-ngx ready!

Built with commit f99ba47

https://deploy-preview-2254--fundamental-ngx.netlify.com

Development automation moved this from In progress to Reviewer approved Apr 2, 2020
@rengare rengare changed the title docs: replace broken toolbar with Shellbar docs: broken toolbar replaced by Shellbar Apr 2, 2020
@rengare rengare requested a review from a team April 2, 2020 14:43
@rengare
Copy link
Contributor Author

rengare commented Apr 2, 2020

I changed the title to fix because I touched product menu

@rengare rengare changed the title docs: broken toolbar replaced by Shellbar fix: broken toolbar replaced by Shellbar Apr 3, 2020
@rengare rengare merged commit 54d061e into master Apr 3, 2020
Development automation moved this from Reviewer approved to Done Apr 3, 2020
@rengare rengare deleted the fix/toolbar-replaced-by-shellbar branch April 3, 2020 08:34
sKudum pushed a commit that referenced this pull request Apr 14, 2020
fix:  broken toolbar replaced by Shellbar (#2254)

* fix: broken toolpar repalced by shellbar

* fixed issue with navigation, optional href for product menu

chore(release): version 0.16.0-rc.51 build 6990 [ci skip]

test:add inline help story to storybook (#2256)

chore(release): version 0.16.0-rc.52 build 6997 [ci skip]

chore: support for multiple directive in cssclassbuilder added (#2249)

* feat: added support for multiple directive's classes in cssclassbuilder

* feat: moved helper functions to separate files

* small improvement

chore(release): version 0.16.0-rc.53 build 7008 [ci skip]

fix:platform button styles update to 0.7

fix/2111 updating platform button styles to 0.7
sKudum pushed a commit that referenced this pull request Apr 14, 2020
fix:  broken toolbar replaced by Shellbar (#2254)

* fix: broken toolpar repalced by shellbar

* fixed issue with navigation, optional href for product menu

chore(release): version 0.16.0-rc.51 build 6990 [ci skip]

test:add inline help story to storybook (#2256)

chore(release): version 0.16.0-rc.52 build 6997 [ci skip]

chore: support for multiple directive in cssclassbuilder added (#2249)

* feat: added support for multiple directive's classes in cssclassbuilder

* feat: moved helper functions to separate files

* small improvement

chore(release): version 0.16.0-rc.53 build 7008 [ci skip]

fix:platform button styles update to 0.7

fix/2111 updating platform button styles to 0.7

fix:platform button updated to styles 0.8

fix:platform button styles updated as per 0.7 styles fiori3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation There is an issue with documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants