-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: broken toolbar replaced by Shellbar #2254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rengare
added
bug
Something isn't working
documentation
There is an issue with documentation
v.0.16.0
labels
Apr 2, 2020
InnaAtanasova
changed the title
fix: broken toolpar repalced by shellbar
docs: replace broken toolbar with Shellbar
Apr 2, 2020
Deploy preview for fundamental-ngx ready! Built with commit f99ba47 |
InnaAtanasova
approved these changes
Apr 2, 2020
rengare
changed the title
docs: replace broken toolbar with Shellbar
docs: broken toolbar replaced by Shellbar
Apr 2, 2020
I changed the title to fix because I touched product menu |
mikerodonnell89
approved these changes
Apr 2, 2020
rengare
changed the title
docs: broken toolbar replaced by Shellbar
fix: broken toolbar replaced by Shellbar
Apr 3, 2020
salarenko
approved these changes
Apr 3, 2020
sKudum
pushed a commit
that referenced
this pull request
Apr 14, 2020
fix: broken toolbar replaced by Shellbar (#2254) * fix: broken toolpar repalced by shellbar * fixed issue with navigation, optional href for product menu chore(release): version 0.16.0-rc.51 build 6990 [ci skip] test:add inline help story to storybook (#2256) chore(release): version 0.16.0-rc.52 build 6997 [ci skip] chore: support for multiple directive in cssclassbuilder added (#2249) * feat: added support for multiple directive's classes in cssclassbuilder * feat: moved helper functions to separate files * small improvement chore(release): version 0.16.0-rc.53 build 7008 [ci skip] fix:platform button styles update to 0.7 fix/2111 updating platform button styles to 0.7
sKudum
pushed a commit
that referenced
this pull request
Apr 14, 2020
fix: broken toolbar replaced by Shellbar (#2254) * fix: broken toolpar repalced by shellbar * fixed issue with navigation, optional href for product menu chore(release): version 0.16.0-rc.51 build 6990 [ci skip] test:add inline help story to storybook (#2256) chore(release): version 0.16.0-rc.52 build 6997 [ci skip] chore: support for multiple directive in cssclassbuilder added (#2249) * feat: added support for multiple directive's classes in cssclassbuilder * feat: moved helper functions to separate files * small improvement chore(release): version 0.16.0-rc.53 build 7008 [ci skip] fix:platform button styles update to 0.7 fix/2111 updating platform button styles to 0.7 fix:platform button updated to styles 0.8 fix:platform button styles updated as per 0.7 styles fiori3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a brief summary of this pull request.
Toolbar replaced by shellbar
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Before
After