Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calendar newest styles adaptation #2280

Merged
merged 33 commits into from
Apr 10, 2020
Merged

feat: calendar newest styles adaptation #2280

merged 33 commits into from
Apr 10, 2020

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Apr 7, 2020

Please provide a link to the associated issue.

fixes: #2130

Please provide a brief summary of this pull request.

In this PR there are newest styles adaptation changes, including new options and ways to customization. It's worth to say that there is also new view for aggregated year.

New Properties:

[compact]
[markWeekends]
[specialDaysRules]
[showWeekNumbers]
[aggregatedYearGrid]
[yearGrid]
[mobilePortrait]
[mobileLandscape]

Code:

Calendar service now is more complex. It provides functionality for keyboard support for all views, not only year/month as it was before. Those changes also remove setTimeout, which caused some issues/bugs. There are included some new data models and interfaces.

Removed:

[blockFunction] and range block functions: There are only disable function left.

Those changes are applied to calendar, datepicker and datetimepicker

Please check whether the PR fulfills the following requirements

Documentation checklist:

@netlify
Copy link

netlify bot commented Apr 7, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 30fb537

https://deploy-preview-2280--fundamental-ngx.netlify.com

@JKMarkowski JKMarkowski requested review from salarenko and a team April 7, 2020 10:06
@JKMarkowski JKMarkowski added this to In progress in Development via automation Apr 7, 2020
@JKMarkowski JKMarkowski added this to the Sprint 34 - Głogów milestone Apr 7, 2020
@mikerodonnell89
Copy link
Member

For the mobile dialog modes - the specs state there should be some side margins, coming from the dialog


exampleSpecialDays = `Example Special Days Functions:

// Mark weekends with special day number 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section of the docs is a little confusing, at first I thought that the example would use this rule. I think the better option would be to use the more complex rule at the bottom in the example. Or maybe have toggles for different special day functions. Special days could be its own section, in my opinion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, take a look at new section

</component-example>
<code-example [exampleFiles]="calendarGridSource"></code-example>

<separator></separator>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vanessa-Cusmich could you take a look at the doc part? Thanks

@JKMarkowski JKMarkowski changed the title fix: calendar newest styles adaptation feat: calendar newest styles adaptation Apr 8, 2020
@JKMarkowski
Copy link
Contributor Author

For the mobile dialog modes - the specs state there should be some side margins, coming from the dialog

Done

@droshev droshev requested a review from rengare April 8, 2020 14:55
@stefanoScalzo
Copy link
Contributor

stefanoScalzo commented Apr 9, 2020

What if the user had the ability to choose how many years to skip by.
Also not sure if ui5 isn't implementing their click on their year-selector properly or if it is supposed to have a grey highlight when clicked

Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Other moths days should not have background
    image
  • Different month rows/columns ratio
    image
    image
    image
  • Missing header for mobile portrait orientation
    image

There are also multiple places where we call our functions from template. That's probably one of the reasons why calendar has performance issues.

Development automation moved this from In progress to Review in progress Apr 9, 2020
@JKMarkowski
Copy link
Contributor Author

JKMarkowski commented Apr 9, 2020

@stefanoScalzo

What if the user had the ability to choose how many years to skip by.

It's done under the hood, it calculates how much years are displayed at once and switch by this amount

@mikerodonnell89 mikerodonnell89 self-requested a review April 9, 2020 21:02
@droshev droshev self-requested a review April 10, 2020 00:42
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JKMarkowski after opening Date(Time) Picker if you go with Ctrl+tab the focus goes out of the popover

  • there is no rounder corners in the datepicker

@salarenko salarenko dismissed droshev’s stale review April 10, 2020 14:30

Reported issues have been fixed

Development automation moved this from Review in progress to Reviewer approved Apr 10, 2020
@JKMarkowski JKMarkowski merged commit 1543d75 into master Apr 10, 2020
Development automation moved this from Reviewer approved to Done Apr 10, 2020
@JKMarkowski JKMarkowski deleted the feat/calendar branch April 10, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adopt latest calendar styling/markup update
6 participants