-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calendar newest styles adaptation #2280
Conversation
Deploy preview for fundamental-ngx ready! Built with commit 30fb537 |
For the mobile dialog modes - the specs state there should be some side margins, coming from the dialog |
|
||
exampleSpecialDays = `Example Special Days Functions: | ||
|
||
// Mark weekends with special day number 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section of the docs is a little confusing, at first I thought that the example would use this rule. I think the better option would be to use the more complex rule at the bottom in the example. Or maybe have toggles for different special day functions. Special days could be its own section, in my opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, take a look at new section
</component-example> | ||
<code-example [exampleFiles]="calendarGridSource"></code-example> | ||
|
||
<separator></separator> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vanessa-Cusmich could you take a look at the doc part? Thanks
Done |
What if the user had the ability to choose how many years to skip by. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libs/core/src/lib/calendar/calendar-header/calendar-header.component.html
Outdated
Show resolved
Hide resolved
...ar/calendar-views/calendar-aggregated-year-view/calendar-aggregated-year-view.component.html
Show resolved
Hide resolved
...calendar-views/calendar-aggregated-year-view/calendar-aggregated-year-view.component.spec.ts
Outdated
Show resolved
Hide resolved
...ndar/calendar-views/calendar-aggregated-year-view/calendar-aggregated-year-view.component.ts
Outdated
Show resolved
Hide resolved
...ndar/calendar-views/calendar-aggregated-year-view/calendar-aggregated-year-view.component.ts
Outdated
Show resolved
Hide resolved
...ndar/calendar-views/calendar-aggregated-year-view/calendar-aggregated-year-view.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/calendar/calendar-views/calendar-year-view/calendar-year-view.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/calendar/calendar-views/calendar-year-view/calendar-year-view.component.ts
Outdated
Show resolved
Hide resolved
…or keyboard support service
It's done under the hood, it calculates how much years are displayed at once and switch by this amount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JKMarkowski after opening Date(Time) Picker if you go with Ctrl+tab the focus goes out of the popover
- there is no rounder corners in the datepicker
75a221c
to
e2a07e5
Compare
e2a07e5
to
c5d4cff
Compare
Please provide a link to the associated issue.
fixes: #2130
Please provide a brief summary of this pull request.
In this PR there are newest styles adaptation changes, including new options and ways to customization. It's worth to say that there is also new view for aggregated year.
New Properties:
Code:
Calendar service now is more complex. It provides functionality for keyboard support for all views, not only year/month as it was before. Those changes also remove
setTimeout
, which caused some issues/bugs. There are included some new data models and interfaces.Removed:
[blockFunction] and range block functions: There are only disable function left.
Those changes are applied to calendar, datepicker and datetimepicker
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md