Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing class to Shellbar button #2290

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Apr 8, 2020

Please provide a link to the associated issue.

fixes: #2098

Please provide a brief summary of this pull request.

There was missing class on product switch button, which caused old issues with button styling.

Tested on external app

Before:
image

After:
image

Please check whether the PR fulfills the following requirements

Documentation checklist:

@JKMarkowski JKMarkowski requested review from droshev and a team April 8, 2020 11:58
@JKMarkowski JKMarkowski added this to In progress in Development via automation Apr 8, 2020
@JKMarkowski JKMarkowski added this to the Sprint 34 - Głogów milestone Apr 8, 2020
@netlify
Copy link

netlify bot commented Apr 8, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 67d5251

https://deploy-preview-2290--fundamental-ngx.netlify.com

@InnaAtanasova InnaAtanasova changed the title fix: (shellbar) Add missing class to button fix: add missing class to Shellbar button Apr 8, 2020
Development automation moved this from In progress to Reviewer approved Apr 8, 2020
@JKMarkowski JKMarkowski merged commit 4afd9a5 into master Apr 8, 2020
Development automation moved this from Reviewer approved to Done Apr 8, 2020
@JKMarkowski JKMarkowski deleted the fix/shellbar-product-button branch April 8, 2020 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shellbar buttons styling issue
2 participants