-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: radio button reactive form #2311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for fundamental-ngx ready! Built with commit f1dfcfb |
rengare
changed the title
Fix/radio button reactive form
fix: radio button reactive form
Apr 11, 2020
droshev
requested changes
Apr 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errors during build:
8:23:01 PM: ERROR: libs/core/src/lib/radio/radio-button/radio-button.component.html(7,5): Property 'actualValue' does not exist on type 'RadioButtonComponent'.
8:23:01 PM: An unhandled exception occurred: libs/core/src/lib/radio/radio-button/radio-button.component.html(7,5): Property 'actualValue' does not exist on type 'RadioButtonComponent'.
InnaAtanasova
requested changes
Apr 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The radio-button template calls
actualValue
and gives build errors. - In the component file you have
writeValue
which is defined but never used
|
fixed |
droshev
approved these changes
Apr 14, 2020
JKMarkowski
approved these changes
Apr 14, 2020
InnaAtanasova
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Relates #2304
Please provide a brief summary of this pull request.
PR brings fix for radio button inside reactive forms
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md