Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: radio button reactive form #2311

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Conversation

rengare
Copy link
Contributor

@rengare rengare commented Apr 11, 2020

Please provide a link to the associated issue.

Relates #2304

Please provide a brief summary of this pull request.

PR brings fix for radio button inside reactive forms

Please check whether the PR fulfills the following requirements

@netlify
Copy link

netlify bot commented Apr 11, 2020

Deploy preview for fundamental-ngx ready!

Built with commit f1dfcfb

https://deploy-preview-2311--fundamental-ngx.netlify.com

@rengare rengare requested a review from a team April 11, 2020 12:45
@rengare rengare self-assigned this Apr 11, 2020
@rengare rengare added bug Something isn't working v.0.16.0 labels Apr 11, 2020
@rengare rengare added this to In progress in Development via automation Apr 11, 2020
@rengare rengare added this to the Sprint 34 - Głogów milestone Apr 11, 2020
@rengare rengare changed the title Fix/radio button reactive form fix: radio button reactive form Apr 11, 2020
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errors during build:

8:23:01 PM: ERROR: libs/core/src/lib/radio/radio-button/radio-button.component.html(7,5): Property 'actualValue' does not exist on type 'RadioButtonComponent'.
8:23:01 PM: An unhandled exception occurred: libs/core/src/lib/radio/radio-button/radio-button.component.html(7,5): Property 'actualValue' does not exist on type 'RadioButtonComponent'.

Development automation moved this from In progress to Review in progress Apr 12, 2020
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The radio-button template calls actualValue and gives build errors.
  2. In the component file you have writeValue which is defined but never used

@rengare
Copy link
Contributor Author

rengare commented Apr 14, 2020

1. The radio-button template calls `actualValue` and gives build errors.

2. In the component file you have `writeValue` which is defined but never used
  1. writeValue comes from ControlValueAccessor interface implementation, its mandatory

@rengare
Copy link
Contributor Author

rengare commented Apr 14, 2020

errors during build:

8:23:01 PM: ERROR: libs/core/src/lib/radio/radio-button/radio-button.component.html(7,5): Property 'actualValue' does not exist on type 'RadioButtonComponent'.
8:23:01 PM: An unhandled exception occurred: libs/core/src/lib/radio/radio-button/radio-button.component.html(7,5): Property 'actualValue' does not exist on type 'RadioButtonComponent'.

fixed

@InnaAtanasova InnaAtanasova self-requested a review April 14, 2020 13:08
Development automation moved this from Review in progress to Reviewer approved Apr 14, 2020
@JKMarkowski JKMarkowski merged commit 5658a47 into master Apr 14, 2020
Development automation moved this from Reviewer approved to Done Apr 14, 2020
@JKMarkowski JKMarkowski deleted the fix/radio-button-reactive-form branch April 14, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants