Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set ViewEncapsulation.None for radio button and split button #2337

Merged
merged 1 commit into from
Apr 14, 2020
Merged

fix: set ViewEncapsulation.None for radio button and split button #2337

merged 1 commit into from
Apr 14, 2020

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Apr 14, 2020

Please provide a link to the associated issue.

relates #2334

@droshev droshev added the bug Something isn't working label Apr 14, 2020
@droshev droshev requested a review from a team April 14, 2020 03:21
@droshev droshev self-assigned this Apr 14, 2020
@droshev droshev added this to In progress in Development via automation Apr 14, 2020
@droshev droshev mentioned this pull request Apr 14, 2020
Closed
14 tasks
@netlify
Copy link

netlify bot commented Apr 14, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 497b4ac

https://deploy-preview-2337--fundamental-ngx.netlify.com

Development automation moved this from In progress to Reviewer approved Apr 14, 2020
rengare
rengare suggested changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@rengare rengare left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select button height is not correct
image
EDIT
The fix is provided in another PR

Development automation moved this from Reviewer approved to Review in progress Apr 14, 2020
Development automation moved this from Review in progress to Reviewer approved Apr 14, 2020
JKMarkowski
JKMarkowski approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@JKMarkowski JKMarkowski merged commit 8bd28b8 into master Apr 14, 2020
Development automation moved this from Reviewer approved to Done Apr 14, 2020
@JKMarkowski JKMarkowski deleted the fix/add-view-encapsulation-none branch April 14, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rengare rengare rengare approved these changes

@JKMarkowski JKMarkowski JKMarkowski approved these changes

Assignees

@droshev droshev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@droshev @rengare @JKMarkowski