Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support Calendar key navigation | IE11 #2342

Merged
merged 1 commit into from
Apr 14, 2020
Merged

fix: Support Calendar key navigation | IE11 #2342

merged 1 commit into from
Apr 14, 2020
+6 −1

Conversation

salarenko
Copy link
Contributor

@salarenko salarenko commented Apr 14, 2020 •
edited

Please provide a link to the associated issue.

Part of: #2304

Please provide a brief summary of this pull request.

IE11 keyboard events keys have different naming. This PR adds support for IE11 key names.

Please check whether the PR fulfills the following requirements

Documentation checklist:

@salarenko salarenko added the bug Something isn't working label Apr 14, 2020
@salarenko salarenko added this to the Sprint 34 - Głogów milestone Apr 14, 2020
@salarenko salarenko requested a review from a team April 14, 2020 09:27
@salarenko salarenko added this to In progress in Development via automation Apr 14, 2020
@salarenko salarenko mentioned this pull request Apr 14, 2020
Closed
@netlify
Copy link

netlify bot commented Apr 14, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 1caed7c

https://deploy-preview-2342--fundamental-ngx.netlify.com

Development automation moved this from In progress to Reviewer approved Apr 14, 2020
JKMarkowski
JKMarkowski approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testsed on IE11, works well

@JKMarkowski JKMarkowski merged commit f89e643 into master Apr 14, 2020
Development automation moved this from Reviewer approved to Done Apr 14, 2020
@JKMarkowski JKMarkowski deleted the fix/calendar-keyboard-support-IE11 branch April 14, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rengare rengare rengare approved these changes

@JKMarkowski JKMarkowski JKMarkowski approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 34 - Głogów
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@salarenko @rengare @JKMarkowski