Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix sidebar squashing, add icons to shared module #2370

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a brief summary of this pull request.

Latest Docs Issues:
Sidebar - collapse, when not fullfiled.
Menu Icon - Added module to shared modules.
Before:
image

After:
IE11:
image
Opera:
image

Please check whether the PR fulfills the following requirements

Documentation checklist:

@JKMarkowski JKMarkowski added this to the Sprint 35 - Nysa milestone Apr 16, 2020
@JKMarkowski JKMarkowski requested a review from a team April 16, 2020 15:07
@JKMarkowski JKMarkowski self-assigned this Apr 16, 2020
@JKMarkowski JKMarkowski added this to In progress in Development via automation Apr 16, 2020
@netlify
Copy link

netlify bot commented Apr 16, 2020

Deploy preview for fundamental-ngx ready!

Built with commit fbc8a25

https://deploy-preview-2370--fundamental-ngx.netlify.app

@InnaAtanasova InnaAtanasova changed the title docs: Fix sidebar squashing, add icons to shared module docs: fix sidebar squashing, add icons to shared module Apr 16, 2020
Development automation moved this from In progress to Reviewer approved Apr 16, 2020
@InnaAtanasova
Copy link
Contributor

Wrong label ;)

@salarenko salarenko self-requested a review April 17, 2020 09:03
@salarenko salarenko added the documentation There is an issue with documentation label Apr 17, 2020
@JKMarkowski JKMarkowski merged commit cdd7cf0 into master Apr 17, 2020
Development automation moved this from Reviewer approved to Done Apr 17, 2020
@JKMarkowski JKMarkowski deleted the docs/sidebar-fix branch April 17, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation There is an issue with documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants