feat: Side Navigation styles markup adaptation #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 5dfc147 |
JKMarkowski
force-pushed
the
fix/side-navigation-changes
branch
3 times, most recently
from
ed601de
to
7c5c784
Compare
JKMarkowski
changed the title
|
List item with icon has a different focus outline |
|
Issue with the border on selected items |
|
Items should not have these outlines I think |
mikerodonnell89
requested changes
May 11, 2020
|
@mikerodonnell89 It looks completely different than local examples. After rebasing, there was wrong version of |
mikerodonnell89
requested changes
May 12, 2020
rengare
suggested changes
May 13, 2020
libs/core/src/lib/nested-list/nested-list-popover/nested-list-popover.component.ts
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-item/nested-item.directive.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-item/nested-item.directive.ts
Outdated
Show resolved
Hide resolved
|
Pushed a commit to this branch addressing this issue: #2392 |
rengare
approved these changes
May 15, 2020
salarenko
suggested changes
May 15, 2020
.../examples/side-navigation-condensed-example/side-navigation-condensed-example.component.html
Outdated
Show resolved
Hide resolved
...pp/core/component-docs/side-navigation/examples/side-navigation-icons-example.component.html
Show resolved
Hide resolved
...avigation-multiple-selected-example/side-navigation-multiple-selected-example.component.html
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-content/nested-list-content.directive.spec.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-item/nested-item.directive.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-list-popover/nested-list-popover.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-list-popover/nested-list-popover.component.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/nested-list/nested-list/nested-list.directive.ts
Outdated
Show resolved
Hide resolved
JKMarkowski
changed the title
JKMarkowski
force-pushed
the
fix/side-navigation-changes
branch
from
b8c0d03
to
a75fdb3
Compare
JKMarkowski
force-pushed
the
fix/side-navigation-changes
branch
from
1123133
to
b14de31
Compare
|
@InnaAtanasova I can't reproduce it. Maybe you had some old cached preview |
salarenko
approved these changes
Jun 1, 2020
mikerodonnell89
approved these changes
Jun 1, 2020
fkolar
pushed a commit
that referenced
this pull request
Jun 5, 2020
* feat: Side Navigation styles markup adaptation * Add tests * Fix comments * Update package-lock.json * Add comments, fix rtl on side nav condensed popover * remove focused tests * Add PR comments * remove focus outline overrides * add PR comments * Add transparent button * Remove non-direct imports, add tests for aggregated directives * Remove public accessors, remove unused imports, move properties * fix tests * update styles * Remove unused parameter on host listener * Fix focus on children elements for parent item * dd selection on click, remove arrowright/left handling * remove focused test * Fix lint * fix tests for side nav keyboard support * Fix programatically changed example * fix selected state in object generated examples Co-authored-by: Mike O'Donnell <mikerodonnell89@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Please provide a brief summary of this pull request.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
Documentation checklist:
README.md