Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(File Input): Deprecate File Input component. #3047

Merged
merged 4 commits into from
Sep 9, 2020
Merged

fix(File Input): Deprecate File Input component. #3047

merged 4 commits into from
Sep 9, 2020

Conversation

manu-kr
Copy link
Contributor

@manu-kr manu-kr commented Aug 19, 2020

Please provide a link to the associated issue.

#3042

Please provide a brief summary of this pull request.

Remove File Input component from Ngx core, As we introduced new File Uploader component.

Please check whether the PR fulfills the following requirements

Documentation checklist:

@manu-kr manu-kr self-assigned this Aug 19, 2020
@manu-kr manu-kr added the core Core library specific issues label Aug 19, 2020
@netlify
Copy link

netlify bot commented Aug 19, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 3f4a3a9

https://deploy-preview-3047--fundamental-ngx.netlify.app

@droshev droshev changed the title Feat(File Input): Remove File Input component fix(File Input): Remove File Input component Aug 20, 2020
KevinOkamoto
KevinOkamoto approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@KevinOkamoto KevinOkamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@droshev droshev requested a review from a team August 21, 2020 20:13
salarenko
salarenko reviewed Aug 24, 2020
View reviewed changes
Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I think you missed apps/docs/src/app/core/api-files.ts

stefanoScalzo
stefanoScalzo approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@stefanoScalzo stefanoScalzo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just remove the FileInputComponent in apps/docs/src/app/core/api-files.ts

droshev
droshev requested changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should deprecate this component for at least 1-2 releases before removing it

@manu-kr
Copy link
Contributor Author

manu-kr commented Aug 26, 2020

I think we should deprecate this component for at least 1-2 releases before removing it

Can you please explain the process to deprecate.

@droshev
Copy link
Contributor

droshev commented Aug 27, 2020

I think we should deprecate this component for at least 1-2 releases before removing it

Can you please explain the process to deprecate.

you can see examples with deprecated components/directives/documentation

@InnaAtanasova
Copy link
Contributor

Please fix the title, this is not following the naming guidelines!

droshev
droshev requested changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment •
edited by manu-kr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments are not addressed

I will address today.

@manu-kr manu-kr changed the title fix(File Input): Remove File Input component Feat(File Input): Deprecate File Input component. Sep 4, 2020
@manu-kr manu-kr requested a review from droshev September 4, 2020 18:29
@manu-kr
Copy link
Contributor Author

manu-kr commented Sep 4, 2020

the comments are not addressed

I will address today.

I have addressed your comments. Please have a look.

@droshev droshev added this to the Sprint 45 - ariba milestone Sep 9, 2020
@droshev droshev added this to In progress in Development via automation Sep 9, 2020
droshev
droshev approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Development automation moved this from In progress to Reviewer approved Sep 9, 2020
@droshev droshev changed the title Feat(File Input): Deprecate File Input component. fix(File Input): Deprecate File Input component. Sep 9, 2020
@manu-kr
Copy link
Contributor Author

manu-kr commented Sep 9, 2020

Deprecating file input component.

@manu-kr manu-kr merged commit c2321a8 into master Sep 9, 2020
Development automation moved this from Reviewer approved to Done Sep 9, 2020
@manu-kr manu-kr deleted the feat/file-input branch September 9, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@KevinOkamoto KevinOkamoto KevinOkamoto approved these changes

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

@rengare rengare Awaiting requested review from rengare

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

@salarenko salarenko Awaiting requested review from salarenko

@stefanoScalzo stefanoScalzo Awaiting requested review from stefanoScalzo

Assignees

@manu-kr manu-kr

Labels
core Core library specific issues
Projects
None yet
Milestone
Sprint 45 - ariba
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@manu-kr @droshev @InnaAtanasova @salarenko @KevinOkamoto @stefanoScalzo