Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: time picker meridian input #3053

Merged
merged 4 commits into from
Aug 21, 2020
Merged

fix: time picker meridian input #3053

merged 4 commits into from
Aug 21, 2020

Conversation

stefanoScalzo
Copy link
Contributor

@stefanoScalzo stefanoScalzo commented Aug 19, 2020 •
edited

Please provide a link to the associated issue.

fixes: #2885

Please provide a brief summary of this pull request.

Fixes the meridian issue due to wrong variable

Please check whether the PR fulfills the following requirements

Documentation checklist:

@stefanoScalzo stefanoScalzo added the bug Something isn't working label Aug 19, 2020
@stefanoScalzo stefanoScalzo added this to the Sprint 44 - Cairo milestone Aug 19, 2020
@stefanoScalzo stefanoScalzo requested review from JKMarkowski and a team August 19, 2020 19:03
@stefanoScalzo stefanoScalzo added this to In progress in Development via automation Aug 19, 2020
@stefanoScalzo stefanoScalzo self-assigned this Aug 19, 2020
@netlify
Copy link

netlify bot commented Aug 19, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit dd7d664

https://deploy-preview-3053--fundamental-ngx.netlify.app

Development automation moved this from In progress to Review in progress Aug 20, 2020
salarenko
salarenko suggested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using variable with private access modifier in the template. Create getter for meridian and use it properly.

@salarenko salarenko added the core Core library specific issues label Aug 20, 2020
@stefanoScalzo
Copy link
Contributor Author

You are using variable with private access modifier in the template. Create getter for meridian and use it properly.

fixed

@stefanoScalzo stefanoScalzo requested a review from a team August 20, 2020 14:07
Development automation moved this from Review in progress to Reviewer approved Aug 20, 2020
@stefanoScalzo stefanoScalzo merged commit 9ada0fc into master Aug 21, 2020
Development automation moved this from Reviewer approved to Done Aug 21, 2020
@stefanoScalzo stefanoScalzo deleted the fix-datetimepicker-locale branch August 21, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salarenko salarenko salarenko approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

Assignees

@stefanoScalzo stefanoScalzo

Labels
bug Something isn't working core Core library specific issues
Projects
None yet
Milestone
Sprint 44 - Cairo
Development

Successfully merging this pull request may close these issues.

DateTime-Picker: Event-handler gets old data is user changes data manually in locales different than "en-US"
3 participants
@stefanoScalzo @salarenko @InnaAtanasova