Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Time performance #3166

Merged
merged 1 commit into from
Sep 1, 2020
Merged

fix: Time performance #3166

merged 1 commit into from
Sep 1, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

fixes: #3133

Please provide a brief summary of this pull request.

In this PR there is added destroy() method on hammer js, when the time component is destroyed.

Please check whether the PR fulfills the following requirements

Documentation checklist:

@JKMarkowski JKMarkowski added bug Something isn't working core Core library specific issues performance labels Aug 31, 2020
@JKMarkowski JKMarkowski added this to the Sprint 45 - Berlin milestone Aug 31, 2020
@JKMarkowski JKMarkowski requested review from zaheral and a team August 31, 2020 11:58
@JKMarkowski JKMarkowski added this to In progress in Development via automation Aug 31, 2020
@netlify
Copy link

netlify bot commented Aug 31, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 377c6c7

https://deploy-preview-3166--fundamental-ngx.netlify.app

mikerodonnell89
mikerodonnell89 approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@mikerodonnell89 mikerodonnell89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Development automation moved this from In progress to Reviewer approved Aug 31, 2020
@JKMarkowski JKMarkowski merged commit 0953b63 into master Sep 1, 2020
Development automation moved this from Reviewer approved to Done Sep 1, 2020
@JKMarkowski JKMarkowski deleted the fix/performance-3133 branch September 1, 2020 09:24
JKMarkowski added a commit that referenced this pull request Sep 2, 2020
@JKMarkowski
fix: Time performance (#3166)
afaa5aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@zaheral zaheral Awaiting requested review from zaheral

Assignees
No one assigned
Labels
bug Something isn't working core Core library specific issues performance
Projects
None yet
Milestone
Sprint 45 - Berlin
Development

Successfully merging this pull request may close these issues.

Performance issues with Time- and Datetime-Picker
2 participants
@JKMarkowski @mikerodonnell89