Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Transform form-control to component #3183

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Conversation

JKMarkowski
Copy link
Contributor

@JKMarkowski JKMarkowski commented Sep 1, 2020

Please provide a link to the associated issue.

fixes: #3084

Please provide a brief summary of this pull request.

There is changed form-control directive to component, so it contains styles now

Please check whether the PR fulfills the following requirements

Documentation checklist:

@JKMarkowski JKMarkowski added bug Something isn't working core Core library specific issues labels Sep 1, 2020
@JKMarkowski JKMarkowski added this to the Sprint 45 - Berlin milestone Sep 1, 2020
@JKMarkowski JKMarkowski requested a review from a team September 1, 2020 13:58
@JKMarkowski JKMarkowski added this to In progress in Development via automation Sep 1, 2020
@JKMarkowski JKMarkowski self-assigned this Sep 1, 2020
Development automation moved this from In progress to Reviewer approved Sep 1, 2020
@netlify
Copy link

netlify bot commented Sep 1, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 84ef728

https://deploy-preview-3183--fundamental-ngx.netlify.app

@dimamarksman
Copy link
Contributor

I guess we have to remove input styles from FormItemComponent as it doesn't make sense anymore

@import '~fundamental-styles/dist/input';
@import '~fundamental-styles/dist/textarea';
@import '~fundamental-styles/dist/form-select';

@JKMarkowski what do you think?

@JKMarkowski
Copy link
Contributor Author

I guess we have to remove input styles from FormItemComponent as it doesn't make sense anymore

@import '~fundamental-styles/dist/input';
@import '~fundamental-styles/dist/textarea';
@import '~fundamental-styles/dist/form-select';

@JKMarkowski what do you think?

Hello @dimamarksman yes, it has been already done in this PR
image

@dimamarksman
Copy link
Contributor

I guess we have to remove input styles from FormItemComponent as it doesn't make sense anymore

@import '~fundamental-styles/dist/input';
@import '~fundamental-styles/dist/textarea';
@import '~fundamental-styles/dist/form-select';

@JKMarkowski what do you think?

Hello @dimamarksman yes, it has been already done in this PR
image

Sorry, somehow missed it.
@JKMarkowski Thanks!

@JKMarkowski JKMarkowski merged commit 69989b0 into master Sep 2, 2020
Development automation moved this from Reviewer approved to Done Sep 2, 2020
@JKMarkowski JKMarkowski deleted the fix/form-control-styles branch September 2, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core library specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fd-form-control does not include required styles
3 participants