Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multi input should attach to body #3193

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

mikerodonnell89
Copy link
Member

fixes #3000

@mikerodonnell89 mikerodonnell89 added the bug Something isn't working label Sep 3, 2020
@mikerodonnell89 mikerodonnell89 added this to the Sprint 45 - Berlin milestone Sep 3, 2020
@mikerodonnell89 mikerodonnell89 requested a review from a team September 3, 2020 22:02
@mikerodonnell89 mikerodonnell89 added this to In progress in Development via automation Sep 3, 2020
@mikerodonnell89 mikerodonnell89 self-assigned this Sep 3, 2020
@netlify
Copy link

netlify bot commented Sep 3, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 70b1057

https://deploy-preview-3193--fundamental-ngx.netlify.app

@@ -9,6 +9,7 @@
[disabled]="disabled"
[closeOnOutsideClick]="true"
[fillControlMode]="fillControlMode"
[appendTo]="'body'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to static string binding

Development automation moved this from In progress to Review in progress Sep 4, 2020
Development automation moved this from Review in progress to Reviewer approved Sep 7, 2020
@mikerodonnell89 mikerodonnell89 merged commit ba0760f into master Sep 8, 2020
Development automation moved this from Reviewer approved to Done Sep 8, 2020
@mikerodonnell89 mikerodonnell89 deleted the fix/#3000-multi-select-modal-footer branch September 8, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi select menu goes below the modal footer
3 participants