fix: Bring valid selection into multi input component #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit ef47910 |
mikerodonnell89
requested changes
Sep 9, 2020
| @@ -68,6 +68,10 @@ export class ListItemComponent implements KeyboardSupportItemInterface, AfterCon | |||
| @HostBinding('class.fd-list__item--link') | |||
| link = false; | |||
|
|
|||
| /** Defines if list item is used inside MultiInputComponent */ | |||
There was a problem hiding this comment.
At the very least this should be hidden from the app developer, but I think we do not need to use an input at all, the multi-input could get list item content children and set the property there. Or this list item could ascend a few parents and figure out if it is in a multi input.
There was a problem hiding this comment.
@mikerodonnell89 You are right, it should be controlled from parent. Anyway it has been changed, so now it uses selection list for multi input with some minor styles adjustments.
JKMarkowski
force-pushed
the
fix/multi-input-selection
branch
from
c303a61
to
361749f
Compare
salarenko
approved these changes
Sep 11, 2020
mikerodonnell89
requested changes
Sep 14, 2020
mikerodonnell89
approved these changes
Sep 17, 2020
InnaAtanasova
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
part of #3085
Please provide a brief summary of this pull request.
Now multi input uses same structure as list with selection. Temporary there are added some styles, to keep fiori3 design.
Also there is fixed focusing/selecting items by keyboard
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist