Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (platform) fix for textarea breaking #3221

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

kavya-b
Copy link
Contributor

@kavya-b kavya-b commented Sep 8, 2020

Please provide a link to the associated issue.

#3086

Please provide a brief summary of this pull request.

  • FormMessage had to be imported in the docs for one of the examples, without which the 'without Platform Forms' example was showing some broken form message styling.
  • Removed custom class added to example
  • The ElementRef being used was, for some reason, not able to get the component's reference. This was fixed by using the read attribute.
  • Fix for width issue by overriding the fd-popover styles. A similar fix is already being used in core.
  • Using only required FormControlModule iinstead of loading entire core FdFormModule in textarea module.

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples
  • Stackblitz works for all examples

@kavya-b kavya-b added bug Something isn't working platform platform labels Sep 8, 2020
@netlify
Copy link

netlify bot commented Sep 8, 2020

Deploy preview for fundamental-ngx ready!

Built with commit c6de72b

https://deploy-preview-3221--fundamental-ngx.netlify.app

Copy link
Member

@KevinOkamoto KevinOkamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

droshev
droshev previously requested changes Sep 8, 2020
Copy link
Contributor

@droshev droshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The overlay is not properly attached to the text

Screen Shot 2020-09-08 at 5 57 32 PM

area

There are cases where it is fine
Screen Shot 2020-09-08 at 5 58 38 PM

  • first click on a textarea with message shows the message shifted:
    textarea

@kavya-b
Copy link
Contributor Author

kavya-b commented Sep 9, 2020

  • The overlay is not properly attached to the text
Screen Shot 2020-09-08 at 5 57 32 PM

area
There are cases where it is fine
Screen Shot 2020-09-08 at 5 58 38 PM

  • first click on a textarea with message shows the message shifted:
    textarea

@droshev This seems to be a problem with the form-message handling at the Platform Forms level and needs to be explored. I have created issue #3229 for this and will look into this at a later point after the release. Since this PR needs to go through for release and these issues are not blocking, please approve it.

@kavya-b kavya-b dismissed droshev’s stale review September 11, 2020 13:56

separate issue created for other form message related issues as mentioned in the previous comment. Dismissing this to unblock merging.

@kavya-b kavya-b merged commit b75c902 into master Sep 11, 2020
@kavya-b kavya-b deleted the fix-textarea-breaking branch September 11, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform platform
Projects
No open projects
Platform Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants