Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (platform) fix of defects related to Search Field #3237

Merged
merged 6 commits into from
Sep 17, 2020

Conversation

KevinOkamoto
Copy link
Member

Please provide a link to the associated issue.

#3086

Please provide a brief summary of this pull request.

The following issues were addressed:

  • Platform Search Field: on button hover has wrong styling
  • Platform Search Field: the search input is modifying the results and is also case sensitive when camelcasing is part of the word
  • Platform Search Field: when long list of data is present and you search a substring, the result popover does not stick to the search field and instead floats.
  • Platform Search Filed: Without entering the letter or character autosuggestion is showing, and entering the space bar auto suggestion is showing
  • Platform Search Field: Category is not closing even after selected the category from the keyboard.

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples

* Added optional '<span>' tags to highlight result which allows spaces to be displayed
* Added "closeSuggestionMenu" step before creating a new one, so that menu appears to stay attached
@KevinOkamoto KevinOkamoto added bug Something isn't working platform platform 0.22.0 labels Sep 9, 2020
@netlify
Copy link

netlify bot commented Sep 9, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 9250649

https://deploy-preview-3237--fundamental-ngx.netlify.app

@puru-hk
Copy link
Contributor

puru-hk commented Sep 10, 2020

Tested this issue it is working fine.

@InnaAtanasova
Copy link
Contributor

Search Field with Categories has the following issue:
type something in the input field -> Input Change Text updates with the value
delete the value using the delete key, not the cleat button -> one letter of the value remains.

See screenshots:

Screen Shot 2020-09-10 at 4 55 27 PM

Screen Shot 2020-09-10 at 4 55 34 PM

Screen Shot 2020-09-10 at 4 55 12 PM

Screen Shot 2020-09-10 at 4 55 20 PM

Copy link
Contributor

@sKudum sKudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinOkamoto
Copy link
Member Author

@InnaAtanasova I fixed issue with input text not updating on deletion of last character.

@stefanoScalzo
Copy link
Contributor

Should take into account spaces, type in Apple with a space, nothing should be there but both apple and pineapple are there

Copy link
Contributor

@stefanoScalzo stefanoScalzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@dimamarksman
Copy link
Contributor

LGTM

@KevinOkamoto
Copy link
Member Author

KevinOkamoto commented Sep 15, 2020

@stefanoScalzo Is there a use-case for including leading whitespace in a search term? I can maybe see a case for including trailing whitespace in the search term. Most search fields I've used ignore leading white-space.

However, I can see a use case where application requirements may want to have a "starts-with" matching algorithm, but then that will be applied within the user provided data source and not applied within the component.

@stefanoScalzo
Copy link
Contributor

where

The UI5 Example takes into account whitespaces

@KevinOkamoto
Copy link
Member Author

KevinOkamoto commented Sep 16, 2020

The UI5 Example takes into account whitespaces

@stefanoScalzo The UI5 Example is also has the following defect mentioned in the defect list:

Search Filed: Without entering the letter or character autosuggestion is showing. And entering the space bar auto suggestion is showing. to be fixed(suggestions should appear only if atleast one character is input by the user)

in that if you type in one space character, it is matching all strings with one space in the string.

Screen Shot 2020-09-16 at 7 36 55 AM

Isn't it better user experience to trim leading whitespace? In my experience, leading whitespace in the search term is usually done by accident, like when the user cuts-and-pastes a string into the search field.

@KevinOkamoto KevinOkamoto merged commit cc12e3b into master Sep 17, 2020
@KevinOkamoto KevinOkamoto deleted the fix/search-field-issues branch September 17, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants