-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (platform) fix of defects related to Search Field #3237
Conversation
* Added optional '<span>' tags to highlight result which allows spaces to be displayed * Added "closeSuggestionMenu" step before creating a new one, so that menu appears to stay attached
Deploy preview for fundamental-ngx ready! Built with commit 9250649 |
Tested this issue it is working fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@InnaAtanasova I fixed issue with input text not updating on deletion of last character. |
Should take into account spaces, type in Apple with a space, nothing should be there but both apple and pineapple are there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
LGTM |
@stefanoScalzo Is there a use-case for including leading whitespace in a search term? I can maybe see a case for including trailing whitespace in the search term. Most search fields I've used ignore leading white-space. However, I can see a use case where application requirements may want to have a "starts-with" matching algorithm, but then that will be applied within the user provided data source and not applied within the component. |
The UI5 Example takes into account whitespaces |
@stefanoScalzo The UI5 Example is also has the following defect mentioned in the defect list:
in that if you type in one space character, it is matching all strings with one space in the string. Isn't it better user experience to trim leading whitespace? In my experience, leading whitespace in the search term is usually done by accident, like when the user cuts-and-pastes a string into the search field. |
Please provide a link to the associated issue.
#3086
Please provide a brief summary of this pull request.
The following issues were addressed:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist: