Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (platform) button issues fix after defect hunt #3249

Merged
merged 1 commit into from
Sep 11, 2020
Merged

fix: (platform) button issues fix after defect hunt #3249

merged 1 commit into from
Sep 11, 2020

Conversation

sKudum
Copy link
Contributor

@sKudum sKudum commented Sep 10, 2020

Please provide a link to the associated issue.

#3205
#3245

Please provide a brief summary of this pull request.

removal of [] from the documentation.
properties alignment as per angular styling guidelines, along with type attribute.

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples
  • Stackblitz works for all examples

@netlify
Copy link

netlify bot commented Sep 10, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 3a398ec

https://deploy-preview-3249--fundamental-ngx.netlify.app

KevinOkamoto
KevinOkamoto approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@KevinOkamoto KevinOkamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@droshev droshev added this to In progress in Development via automation Sep 10, 2020
@droshev droshev added this to the Sprint 45 - ariba milestone Sep 10, 2020
Development automation moved this from In progress to Reviewer approved Sep 10, 2020
@sKudum sKudum merged commit 95d1355 into master Sep 11, 2020
Development automation moved this from Reviewer approved to Done Sep 11, 2020
@sKudum sKudum deleted the fix/platformbuttondefhunt branch September 11, 2020 04:29
@sKudum sKudum mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@KevinOkamoto KevinOkamoto KevinOkamoto approved these changes

@salarenko salarenko Awaiting requested review from salarenko

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 45 - ariba
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sKudum @droshev @InnaAtanasova @KevinOkamoto