Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add partial keyword in DialogConfig #3307

Merged
merged 1 commit into from
Sep 17, 2020
Merged

fix: add partial keyword in DialogConfig #3307

merged 1 commit into from
Sep 17, 2020

Conversation

stefanoScalzo
Copy link
Contributor

@stefanoScalzo stefanoScalzo commented Sep 16, 2020 •
edited

Please provide a link to the associated issue.

fixes: #3106

Please provide a brief summary of this pull request.

Adds partial keyword so not all properties have to be defined in the dialog config with the open message

Please check whether the PR fulfills the following requirements

Documentation checklist:

@stefanoScalzo stefanoScalzo added the bug Something isn't working label Sep 16, 2020
@stefanoScalzo stefanoScalzo added this to the Sprint 46 - Montreal milestone Sep 16, 2020
@stefanoScalzo stefanoScalzo requested review from JKMarkowski and a team September 16, 2020 14:36
@stefanoScalzo stefanoScalzo added this to In progress in Development via automation Sep 16, 2020
@netlify
Copy link

netlify bot commented Sep 16, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 98fe75f

https://deploy-preview-3307--fundamental-ngx.netlify.app

Development automation moved this from In progress to Reviewer approved Sep 17, 2020
@InnaAtanasova InnaAtanasova changed the title fix: add partial keyword fix: add partial keyword in DialogConfig Sep 17, 2020
@InnaAtanasova InnaAtanasova merged commit 7d7aa88 into master Sep 17, 2020
Development automation moved this from Reviewer approved to Done Sep 17, 2020
@InnaAtanasova InnaAtanasova deleted the fix-partial-dialog-config branch September 17, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@Betrozov Betrozov Betrozov approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

@salarenko salarenko Awaiting requested review from salarenko

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 46 - Montreal
Development

Successfully merging this pull request may close these issues.

Dialog config properties are mandatory
4 participants
@stefanoScalzo @mikerodonnell89 @Betrozov @InnaAtanasova