fix: (platform) input group states #3333
Merged
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimamarksman
changed the title
dimamarksman
changed the title
dimamarksman
changed the title
|
Deploy preview for fundamental-ngx ready! Built with commit 25d00e2 |
| @@ -30,7 +30,7 @@ | |||
| <p>Icon as an addon</p> | |||
| <fdp-input-group name="employee" placeholder="Email"> | |||
| <fdp-input-group-addon> | |||
| <i class="sap-icon--email"></i> | |||
| <span class="sap-icon--email" title="Email"></span> | |||
There was a problem hiding this comment.
Why did you change it to a span? Also, you probably need aria-hidden="true" for a11y purposes. You can check some blog posts about it https://a11y-101.com/development/icons-and-links
There was a problem hiding this comment.
It's also in the docs part so you can ignore my comment :) Just wanted to say it's a good to have thing :)
There was a problem hiding this comment.
I added aria-hidden and reverted <span> to <i> (chnaged to span previously because it makes icon in italic, but that's should be fixes once latest fundamental-styles gets released).
Thanks!
InnaAtanasova
approved these changes
Sep 18, 2020
InnaAtanasova
changed the title
dimamarksman
force-pushed
the
fix-platform-input-group-states
branch
from
62fb870
to
25d00e2
Compare
This was referenced Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#3324
#3316
Please provide a brief summary of this pull request.
Added disabled state for fdp-input-group input and addon buttons.
In example added tootlip for an icon.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md