add option for calendar weeks to start on Monday instead of Sunday #334
+36
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerodonnell89
requested review from
droshev,
thomasgauvin and
InnaAtanasova
droshev
approved these changes
Nov 30, 2018
droshev
approved these changes
Nov 30, 2018
| @@ -100,7 +103,7 @@ export class CalendarComponent implements OnInit, OnChanges, AfterViewChecked { | |||
| 'November', | |||
| 'December' | |||
| ]; | |||
| weekDays: string[] = ['S', 'M', 'T', 'W', 'T', 'F', 'S']; | |||
| weekDays: string[]; | |||
| daysPerMonth = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]; | |||
There was a problem hiding this comment.
what if February is 29 days
There was a problem hiding this comment.
there is a function determineDaysInMonth that determines if Feb has 28 or 29 days
| @@ -694,6 +702,7 @@ export class CalendarComponent implements OnInit, OnChanges, AfterViewChecked { | |||
| this.constructCalendar(); | |||
| this.constructCalendarYearsList(); | |||
| } | |||
| this.weekDays = this.mondayStartOfWeek ? ['M', 'T', 'W', 'T', 'F', 'S', 'S'] : ['S', 'M', 'T', 'W', 'T', 'F', 'S']; | |||
There was a problem hiding this comment.
do we need to make this translatable?
There was a problem hiding this comment.
I think so, however I think i18n should be a separate story
droshev
added
bug
InnaAtanasova
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
#332