Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table update A11y regarding to 0.12.0 styles #3385

Merged
merged 1 commit into from
Sep 25, 2020
Merged

fix: table update A11y regarding to 0.12.0 styles #3385

merged 1 commit into from
Sep 25, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a brief summary of this pull request.

this PR contains: table icon update A11y regarding to 0.12.0 styles

Please check whether the PR fulfills the following requirements

@JKMarkowski JKMarkowski added this to the Sprint 46 - Montreal milestone Sep 24, 2020
@JKMarkowski JKMarkowski requested a review from a team September 24, 2020 13:03
@JKMarkowski JKMarkowski added this to In progress in Development via automation Sep 24, 2020
@JKMarkowski JKMarkowski self-assigned this Sep 24, 2020
@netlify
Copy link

netlify bot commented Sep 24, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 8e12d7c

https://deploy-preview-3385--fundamental-ngx.netlify.app

salarenko
salarenko reviewed Sep 25, 2020
View reviewed changes
Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should move role="presentation" in fd-table-icon and set it by default.

@salarenko salarenko added the core Core library specific issues label Sep 25, 2020
@droshev droshev merged commit ba54fcb into master Sep 25, 2020
Development automation moved this from In progress to Done Sep 25, 2020
@droshev droshev deleted the fix/migrate-table-0.12.0 branch September 25, 2020 13:02
JKMarkowski added a commit that referenced this pull request Sep 25, 2020
@JKMarkowski
fix: update A11y regarding to 0.12.0 styles (#3385)
e12a1da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salarenko salarenko salarenko left review comments

@droshev droshev droshev approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@JKMarkowski JKMarkowski

Labels
core Core library specific issues
Projects
None yet
Milestone
Sprint 46 - Montreal
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JKMarkowski @droshev @salarenko @InnaAtanasova