Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adapt Info Label to 0.12.0 Fundamental Styles #3399

Merged
merged 2 commits into from
Sep 25, 2020
Merged

fix: Adapt Info Label to 0.12.0 Fundamental Styles #3399

merged 2 commits into from
Sep 25, 2020
+91 −64

Conversation

salarenko
Copy link
Contributor

@salarenko salarenko commented Sep 25, 2020 •
edited by droshev

Please provide a link to the associated issue.

Part of: #3370

Please provide a brief summary of this pull request.

This PR:

  • Adapts Info Label in Fundamental Styles v0.12.0
  • Changes Info Label into component
  • Deprecates using content projection to pass text content
  • Improves Info Label component tests

BREAKING CHANGE:
###BEFORE:

<span fd-info-label>Text value</span>

###AFTER:

<fd-info-label label="Text value"></fd-info-label>

Please check whether the PR fulfills the following requirements

Documentation checklist:

@salarenko salarenko added icons core Core library specific issues labels Sep 25, 2020
@salarenko salarenko added this to the Sprint 46 - Montreal milestone Sep 25, 2020
@salarenko salarenko requested a review from a team September 25, 2020 11:11
@salarenko salarenko added this to In progress in Development via automation Sep 25, 2020
@salarenko salarenko self-assigned this Sep 25, 2020
@netlify
Copy link

netlify bot commented Sep 25, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit d603ddb

https://deploy-preview-3399--fundamental-ngx.netlify.app

InnaAtanasova
InnaAtanasova reviewed Sep 25, 2020
View reviewed changes
...cs/src/app/core/component-docs/info-label/examples/info-label-default-example.component.html
@@ -1 +1 @@
<span fd-info-label>default label</span>
<fd-info-label label="Default label"></fd-info-label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why you did you change content projection to input prop?

@droshev droshev merged commit 557b761 into master Sep 25, 2020
Development automation moved this from In progress to Done Sep 25, 2020
@droshev droshev deleted the fix/3370-info-label branch September 25, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@salarenko salarenko

Labels
core Core library specific issues
Projects
None yet
Milestone
Sprint 46 - Montreal
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@salarenko @droshev @InnaAtanasova