fix: refactor Object Status to use an input property instead of content projection #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 45f0000 |
InnaAtanasova
force-pushed
the
fix/refactor-object-status
branch
from
169f29d
to
d71e71b
Compare
JKMarkowski
approved these changes
Sep 29, 2020
JKMarkowski
reviewed
Sep 29, 2020
| <a fd-object-status status="critical" glyph="status-critical" clickable="true" label="Critical"></a> | ||
| <a fd-object-status status="positive" glyph="status-positive" clickable="true" label="Positive"></a> | ||
| <a fd-object-status status="informative" glyph="hint" clickable="true" label="Informative"></a> | ||
| <a fd-object-status glyph="to-be-reviewed" clickable="true" label="Default"></a> |
There was a problem hiding this comment.
Boolean values can't have static binding (false would be treated as true won't be applied in this case)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Part of #3420
Please provide a brief summary of this pull request.
Replace the content projection with an input property in order to apply the
<span *ngIf="label" class="fd-object-status__text">{{ label }}</span>conditionally.Before:
After:
BREAKING CHANGE:
Replace the content projection of the Object Status with an input property called
label.