fix: add fix for broken product menu in Shellbar #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 64ecc8d |
JKMarkowski
reviewed
Sep 30, 2020
| <span class="fd-shellbar__title">{{ control }}</span> | ||
| <i class="sap-icon--megamenu fd-shellbar__button--icon"></i> |
There was a problem hiding this comment.
Could you add role tag, or change <i> to fd-icon with fd-shellbar__button--icon?
salarenko
reviewed
Oct 1, 2020
There was a problem hiding this comment.
Hey @InnaAtanasova, why did you decide to switch from MenuButton to Button + Icon?
Is there some styling issue when using Shellbar + MenuButton?
salarenko
approved these changes
Oct 1, 2020
AntonOlkhovskyi
pushed a commit
to AntonOlkhovskyi/fundamental-ngx
that referenced
this pull request
Nov 16, 2020
* fix: add fix for broken product menu in Shellbar * add role to the icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a link to the associated issue.
Part of #3420