Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update Table example #3505

Merged
merged 2 commits into from
Oct 1, 2020
Merged

docs: Update Table example #3505

merged 2 commits into from
Oct 1, 2020

Conversation

salarenko
Copy link
Contributor

Please provide a link to the associated issue.

Part of: #3420

Please provide a brief summary of this pull request.

This PR:

  • Updates Table Dialog with proper selection list markup

Please check whether the PR fulfills the following requirements

Documentation checklist:

@salarenko salarenko added core Core library specific issues Defect Hunting 0.22.0 labels Sep 30, 2020
@salarenko salarenko added this to the Sprint 47 - Bali milestone Sep 30, 2020
@salarenko salarenko requested a review from a team September 30, 2020 09:01
@salarenko salarenko self-assigned this Sep 30, 2020
@salarenko salarenko added this to In progress in Development via automation Sep 30, 2020
@salarenko salarenko mentioned this pull request Sep 30, 2020
Closed
@netlify
Copy link

netlify bot commented Sep 30, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 45ba473

https://deploy-preview-3505--fundamental-ngx.netlify.app

@salarenko salarenko added the documentation There is an issue with documentation label Sep 30, 2020
@InnaAtanasova InnaAtanasova changed the title fix: Update Table example docs: Update Table example Sep 30, 2020
@InnaAtanasova
Copy link
Contributor

Renamed to docs as it's only touching the docs files

JKMarkowski
JKMarkowski suggested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@JKMarkowski JKMarkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Could you use list selection markup from ?
https://fundamental-ngx.netlify.app/#/core/list#selection-list

@salarenko
Copy link
Contributor Author

@JKMarkowski I've added missing title for list elements.

@salarenko salarenko merged commit 42c48ce into master Oct 1, 2020
Development automation moved this from In progress to Done Oct 1, 2020
@salarenko salarenko deleted the fix/3420-table branch October 1, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev droshev approved these changes

@JKMarkowski JKMarkowski JKMarkowski approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@salarenko salarenko

Labels
core Core library specific issues Defect Hunting documentation There is an issue with documentation
Projects
No open projects
Development
  
Done
Milestone
Sprint 47 - Bali
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@salarenko @InnaAtanasova @droshev @JKMarkowski