Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Platform) adding button pressed markup to panel documentation #3584

Merged
merged 3 commits into from Oct 27, 2020

Conversation

krosenk729
Copy link
Contributor

@krosenk729 krosenk729 commented Oct 9, 2020

Please provide a link to the associated issue.

fixes: #3493

Please provide a brief summary of this pull request.

adding button pressed markup to panel documentation

Please check whether the PR fulfills the following requirements

Documentation checklist:

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2020

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 9, 2020

Deploy preview for fundamental-ngx ready!

Built with commit e403b2a

https://deploy-preview-3584--fundamental-ngx.netlify.app

@droshev
Copy link
Contributor

droshev commented Oct 19, 2020

@krosenk729 Thank you for your PR! Would you mind singing the CLA so we can merge the PR?

@krosenk729
Copy link
Contributor Author

@droshev done! sorry for the delay - had to use a different browser for it :)

could you add a hacktoberfest-accepted label to this PR? no worries if you all aren't participating and the answer is 'no'

thanks again

@droshev
Copy link
Contributor

droshev commented Oct 20, 2020

@droshev done! sorry for the delay - had to use a different browser for it :)

could you add a hacktoberfest-accepted label to this PR? no worries if you all aren't participating and the answer is 'no'

thanks again

@krosenk729
I added the label, the CLA seems not kicking

@droshev
Copy link
Contributor

droshev commented Oct 23, 2020

@krosenk729 - can you re-try CLA? i know sometimes it doesn't kick in

@krosenk729
Copy link
Contributor Author

@droshev done! it's still pending. is there anything else I should try? thanks

@droshev droshev added this to In progress in Development via automation Oct 25, 2020
@KharitonOff
Copy link
Member

The commits in this PR are made by @katherinefhc. @krosenk729 please, make sure that @katherinefhc signs the CLA too.

@katherinefhc
Copy link
Contributor

fixed! thanks for your patience

@InnaAtanasova InnaAtanasova removed this from In progress in Development Oct 26, 2020
@JKMarkowski JKMarkowski merged commit e08e74d into SAP:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility:Panel: State “pressed” / “not pressed” about the ‘Toggle Expand’ button is not read
9 participants