-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (Core) refactor Layout Grid with latest changes from fundamental-styles #3640
Conversation
Deploy preview for fundamental-ngx ready! Built with commit fa417c0 |
We need examples of the following
|
I've introduces some changes:
|
We still need to improve the documentation, |
@stefanoScalzo I also thought about the "config" approach, but in this case I find the directives much easier to use and read. Anyway I'm open for discussion, we can talk this through during one of the meetings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is 1 minor thing. I will continue review, after changing directives to inputs, as we discussed
apps/docs/src/app/core/component-docs/layout-grid/layout-grid-docs.component.ts
Outdated
Show resolved
Hide resolved
apps/docs/src/app/core/component-docs/layout-grid/layout-grid-docs.component.ts
Outdated
Show resolved
Hide resolved
@stefanoScalzo @JKMarkowski
Current markup:Columns with breakpoints:
Offset with breakpoints:
|
3da02a0
to
f5201f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! I left 2 minor comments, but the rest LGTM
libs/core/src/lib/layout-grid/directives/layout-grid-col.directive.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/layout-grid/directives/layout-grid-row.directive.ts
Outdated
Show resolved
Hide resolved
The row example should come after before the column example |
Why?
The responsiveness and offsets work together without any additional effort Hmm. you should be able to set them independently from each other |
…ental-ngx into fix/3420-layout-panel
5f70b98
to
c8a4f25
Compare
Layout grid has received a significant refactor with many breaking changes. Note most code in this PR was done by @salarenko and I just wrote tests/docs
Fundamental Styles issues found during implementation:
BREAKING CHANGE:
The layout grid is no longer a series of components but rather directives. Here are a few other breaking changes:
gapSize
input replaced withfdLayoutGridColOffset
nogap
replaced withnoGap
fdLayoutGridCol fdLayoutGridColMd fdLayoutGridColLg fdLayoutGridColXl
fdLayoutGridRow
directive.