feat: implement title component #3707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 2052847 |
InnaAtanasova
requested changes
Oct 30, 2020
Comment on lines
25
to
37
| const headerSize = this._elRef.nativeElement.tagName.charAt(1); | ||
| this._elRef.nativeElement.classList.add('fd-title--h' + headerSize); |
There was a problem hiding this comment.
I think in this case the user should pass the value for the header. The way it's now (Visual example) the compiled code is:
The html tag matches the fd-title--hX class.
In styles it's different:
The idea is that semantically it would make sense to use h1, for example, but the user might want to change the default font-size and have something like:
<h1 class="fd-title fd-title--h6">Title Level 1</h1>
mikerodonnell89
force-pushed
the
feat/title
branch
from
19be410
to
c780c09
Compare
InnaAtanasova
approved these changes
Oct 30, 2020
JKMarkowski
force-pushed
the
feat/title
branch
from
c780c09
to
2052847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3703
Surprise PR as I found this is something we need (in addition to some other things) in order to implement the wizard summary page.