Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Action sheet adapt to newest CDK #3733

Merged
merged 2 commits into from
Nov 5, 2020
Merged

fix: Action sheet adapt to newest CDK #3733

merged 2 commits into from
Nov 5, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

Defect Hunting

Please provide a brief summary of this pull request.

Action sheet was merged in same moment as CKD popover. It method from popover, that don't exist anymore.
So in this PR contains:

  • Removed usage of loaded hook
  • Changed way how it deals with keyboard support - Right now body has to catch event from items.
  • Added onPush strategy on mobile mode
  • Removed leftovers (unnecessary inputs / ActionSheetInterface implmenetation)
  • Added support for dynamically changed items - subscriptions are refreshed.
  • Handle of dynamic change of compact mode.

Breaking Changes:

  • @Input() open => @Input() isOpen
  • @Output() openChange => @Output() isOpenChange

Please check whether the PR fulfills the following requirements

@JKMarkowski JKMarkowski added the core Core library specific issues label Nov 3, 2020
@JKMarkowski JKMarkowski added this to the Sprint 49 - Nassau milestone Nov 3, 2020
@JKMarkowski JKMarkowski requested a review from a team November 3, 2020 13:39
@JKMarkowski JKMarkowski added this to In progress in Development via automation Nov 3, 2020
@JKMarkowski JKMarkowski self-assigned this Nov 3, 2020
@netlify
Copy link

netlify bot commented Nov 3, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 240b358

https://deploy-preview-3733--fundamental-ngx.netlify.app

@JKMarkowski JKMarkowski changed the title fix: Action sheet functionality fix: Action sheet adapt to newest CDK Nov 3, 2020
@stefanoScalzo
Copy link
Contributor

More of a documentation thing, but since we're changing the API, in the document can we write how to achieve it with our inputs

@stefanoScalzo stefanoScalzo self-requested a review November 3, 2020 20:54
Copy link
Contributor

@stefanoScalzo stefanoScalzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, ill create an issue for the docs

@JKMarkowski JKMarkowski merged commit 7b353e8 into master Nov 5, 2020
Development automation moved this from In progress to Done Nov 5, 2020
@JKMarkowski JKMarkowski deleted the fix/action-sheet branch November 5, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants