Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add temporary styles for overflow toolbar #3738

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

part of #3685

Please provide a brief summary of this pull request.

Right now popover-body is rendered outside popover DOM. So styles for .fd-toolbar {} are not visible in fd-toolbar__overflow__body {} anymore. This is already addressed in styles on SAP/fundamental-styles#1851. But it will take time to merge/adapt everything form newest version

@JKMarkowski JKMarkowski added core Core library specific issues Defect Hunting labels Nov 4, 2020
@JKMarkowski JKMarkowski added this to the Sprint 49 - Nassau milestone Nov 4, 2020
@JKMarkowski JKMarkowski requested a review from a team November 4, 2020 11:47
@JKMarkowski JKMarkowski added this to In progress in Development via automation Nov 4, 2020
@JKMarkowski JKMarkowski self-assigned this Nov 4, 2020
@netlify
Copy link

netlify bot commented Nov 4, 2020

Deploy preview for fundamental-ngx ready!

Built with commit bd15154

https://deploy-preview-3738--fundamental-ngx.netlify.app

Copy link
Contributor

@katekozlowska katekozlowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an action point (removing styles...) to this ticket #3684.

@JKMarkowski JKMarkowski merged commit 49f1f78 into master Nov 5, 2020
Development automation moved this from In progress to Done Nov 5, 2020
@JKMarkowski JKMarkowski deleted the fix/toolbar-overflow branch November 5, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues Defect Hunting
Projects
No open projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants