Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (Core) add stronger selector for Message strip #3754

Merged
merged 2 commits into from
Nov 5, 2020
Merged

fix: (Core) add stronger selector for Message strip #3754

merged 2 commits into from
Nov 5, 2020

Conversation

JKMarkowski
Copy link
Contributor

Please provide a link to the associated issue.

part of #3685

Please provide a brief summary of this pull request.

Tested on external app

Before:
image

After:
image

@JKMarkowski JKMarkowski added this to the Sprint 49 - Nassau milestone Nov 5, 2020
@JKMarkowski JKMarkowski requested a review from a team November 5, 2020 08:54
@JKMarkowski JKMarkowski self-assigned this Nov 5, 2020
@JKMarkowski JKMarkowski added this to In progress in Development via automation Nov 5, 2020
@netlify
Copy link

netlify bot commented Nov 5, 2020 •
edited

Deploy preview for fundamental-ngx ready!

Built with commit 401a211

https://deploy-preview-3754--fundamental-ngx.netlify.app

@JKMarkowski JKMarkowski mentioned this pull request Nov 5, 2020
Closed
salarenko
salarenko approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create an issue in Fundamental Styles, to strengthen the selector?

@InnaAtanasova InnaAtanasova self-requested a review November 5, 2020 13:59
InnaAtanasova
InnaAtanasova requested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the naming convention of the PR. You are missing (Core) in the title, add should be with a small letter and message strip should be Message strip

@InnaAtanasova InnaAtanasova changed the title fix: Add stronger selector for message strip fix: (Core) add stronger selector for Message strip Nov 5, 2020
@InnaAtanasova InnaAtanasova self-requested a review November 5, 2020 14:17
@JKMarkowski JKMarkowski merged commit dc1a6a2 into master Nov 5, 2020
Development automation moved this from In progress to Done Nov 5, 2020
@JKMarkowski JKMarkowski deleted the fix/message-strip branch November 5, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salarenko salarenko salarenko approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@JKMarkowski JKMarkowski

Labels
Defect Hunting
Projects
No open projects
Development
  
Done
Milestone
Sprint 49 - Nassau
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JKMarkowski @salarenko @InnaAtanasova