Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Core) cursor on disabled Switch should not be pointer #3769

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

artolshansky
Copy link
Contributor

@artolshansky artolshansky commented Nov 6, 2020

Please provide a link to the associated issue.

fixes #3720

Please provide a brief summary of this pull request.

switch-disabled

Please check whether the PR fulfills the following requirements

Documentation checklist:

  • Documentation Examples
  • Stackblitz works for all examples

@netlify
Copy link

netlify bot commented Nov 6, 2020

Deploy preview for fundamental-ngx ready!

Built with commit 66a2dc0

https://deploy-preview-3769--fundamental-ngx.netlify.app

Copy link
Contributor

@salarenko salarenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just patch the styles here:

.fd-switch.is-disabled {
    cursor: not-allowed;
}

@salarenko salarenko added 0.24.0 core Core library specific issues labels Nov 6, 2020
@salarenko salarenko added this to In progress in Development via automation Nov 6, 2020
@salarenko salarenko added this to the Sprint 49 - Nassau milestone Nov 6, 2020
@artolshansky
Copy link
Contributor Author

We should just patch the styles here:

.fd-switch.is-disabled {
    cursor: not-allowed;
}

@salarenko unfortunately, it won't work
switch-disabled

@droshev droshev merged commit c3e7ec7 into SAP:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues
Projects
No open projects
Platform Development
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

Bug: Cursor on disabled "Switch" should not change state on hover over or should indicate "Not-Allowed".
5 participants