fix: (Platform) add tooltip to the components #3785
Merged
+294
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-ngx ready! Built with commit 3f5c0fb |
|
Deploy preview for fundamental-ngx ready! Built with commit 03e5e55 |
Lokanathan-k
force-pushed
the
Platform_bug_3697
branch
from
b24ed79
to
ec4962e
Compare
InnaAtanasova
requested changes
Nov 9, 2020
...ct-status/platform-object-status-example/platform-object-status-large-example.component.html
Outdated
Show resolved
Hide resolved
...status/platform-object-status-example/platform-object-status-inverted-example.component.html
Outdated
Show resolved
Hide resolved
...tatus/platform-object-status-example/platform-object-status-icon-text-example.component.html
Outdated
Show resolved
Hide resolved
...tform-object-status-example/platform-object-status-clickable-and-icon-example.component.html
Outdated
Show resolved
Hide resolved
Lokanathan-k
changed the title
platform tool tip adding
update the tooltip in paltform
adding title to the examples to add tooltip
Lokanathan-k
force-pushed
the
Platform_bug_3697
branch
from
ea21609
to
75014fd
Compare
sKudum
approved these changes
Nov 10, 2020
...info-label/platform-info-label-example/platform-info-label-aria-label-example.component.html
Outdated
Show resolved
Hide resolved
fixing accessability broken changes
InnaAtanasova
changed the title
InnaAtanasova
changed the title
InnaAtanasova
approved these changes
Nov 10, 2020
|
And please add proper naming for the PR titles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform tool tip adding
Please provide a link to the associated issue.
fixes #3697
Please provide a brief summary of this pull request.
Actual: None of the info label examples have a tooltip.
Expected: info label should have a tooltip on hover.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/master/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist: